Relax some shape checks for rank-1 tensors #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider that rank-1 tensors are "shapeless" and can fit both into [1, N] and [N, 1] tensors, for example. This greatly reduces the need to use .reshape after converting a seq or array into a tensor in assignments, and reduces errors that happen at runtime for code that is conceptually correct. For example, with this change this will work: ``` var t = eye(3, 3) t[_,0] = [1, 2, 3].toTensor ```
AngelEzquerra
force-pushed
the
rank1_tensor_assignment
branch
from
77576b7
to
793754b
Compare
Vindaar
reviewed
Feb 27, 2024
| @@ -175,6 +200,19 @@ proc main() = | |||
|
|
|||
| check: y == exp | |||
|
|
|||
| block: | |||
| # Assigning a rank-1 tensor into an axis of the same size is supported | |||
| # Note that this is not supported by numpy | |||
There was a problem hiding this comment.
Does numpy have a good reason not to support this maybe?
|
Having digested it now, I like it. As it is a breaking change, I made the hardcoded |
Vindaar
force-pushed
the
rank1_tensor_assignment
branch
from
0743154
to
dd220f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider that rank-1 tensors are "shapeless" and can fit both into [1, N] and [N, 1] tensors, for example.
This greatly reduces the need to use .reshape after converting a seq or array into a tensor in assignments, and reduces errors that happen at runtime for code that is conceptually correct. For example, with this change this will work: